Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(billing): remove quantity from backend for nlp add-ons TASK-1482 #5490

Merged
merged 19 commits into from
Feb 17, 2025
Merged

fix(billing): remove quantity from backend for nlp add-ons TASK-1482 #5490

merged 19 commits into from
Feb 17, 2025

Conversation

RuthShryock
Copy link
Member

@RuthShryock RuthShryock commented Feb 5, 2025 •
edited
Loading

💭 Notes

Removed all logic related to handling add-on quantity. Test billing (buying add-ons, upgrading plans, updating submission/storage/nlp usage, etc.) to make sure that nothing is broken.

PR to remove nlp add-on quantity on frontend: #5464

RuthShryock and others added 16 commits January 30, 2025 15:39
@RuthShryock
remove quantity dropdown from nlp addons and fix styling
772355d
@RuthShryock
add padding to dropdown
7c45b8a
@RuthShryock
remove styling fixes and fix style for rendering nlp add-on dropdown
4ea005c
@RuthShryock
Merge branch 'main' into 1482-remove-nlp-addons-dropdown
3f53d79
@RuthShryock
Merge branch 'main' of github.com:kobotoolbox/kpi into 1482-remove-nl…
c7e6a33 
…p-addons-dropdown
@RuthShryock
remove quantity from addons (backend) and adjust tests
d051bcf
@RuthShryock
formatting
65c2ed4
@RuthShryock
fix formatting
a5e5aef
@RuthShryock
fix formatting
1092a61
@RuthShryock
remove quantity dropdown from nlp addons and fix styling
fd48c39
@RuthShryock
add padding to dropdown
44db639
@RuthShryock
remove styling fixes and fix style for rendering nlp add-on dropdown
5499af9
@RuthShryock
remove quantity from all add-on components and calculations
a9c1839
@RuthShryock
fix merge conflicts
c194979
@RuthShryock
remove auto format
9cb028c
@RuthShryock
remove formatting changes
862805c
@RuthShryock RuthShryock self-assigned this Feb 5, 2025
Base automatically changed from 1482-remove-nlp-addons-dropdown to main February 14, 2025 12:35
@jamesrkiger jamesrkiger self-requested a review as a code owner February 14, 2025 12:35
magicznyleszek
magicznyleszek approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@magicznyleszek magicznyleszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE code looks good :)

@RuthShryock RuthShryock merged commit f0f1d7d into main Feb 17, 2025
5 checks passed
@RuthShryock RuthShryock deleted the remove-nlp-addon-quantity-backend branch February 17, 2025 19:59
rgraber pushed a commit that referenced this pull request Feb 18, 2025
@RuthShryock @rgraber
fix(billing): remove quantity from backend for nlp add-ons TASK-1482 (
ce567bb 
#5490)

### 💭 Notes
Removed all logic related to handling add-on quantity. Test billing
(buying add-ons, upgrading plans, updating submission/storage/nlp usage,
etc.) to make sure that nothing is broken.

PR to remove nlp add-on quantity on frontend: #5464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guitlle Guitlle Guitlle approved these changes

@magicznyleszek magicznyleszek magicznyleszek approved these changes

@jamesrkiger jamesrkiger Awaiting requested review from jamesrkiger jamesrkiger is a code owner

Assignees

@RuthShryock RuthShryock

Labels
Back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RuthShryock @Guitlle @magicznyleszek